[DependencyInjection] update service_container.rst #17051
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Aug 14, 2023
|
|
||
| # If you type-hint SiteUpdateManager | ||
| # for a ``$normalUsers`` argument is detected. | ||
| App\Service\SiteUpdateManager $normalUsers: '@site_update_manager.normal_users' |
There was a problem hiding this comment.
@nicolas-grekas can you confirm? TBH I never heard/saw such thing.
Should we add it to the docs?
Thanks
There was a problem hiding this comment.
yes, it's a named autowiring alias, and it's good to tell about it indeed
that being said, we have the service_container/autowiring.rst that already explains what they are.
I think the example should be removed and replaced by a link to that page.
Comment on lines
1195
to
+1198
| If you want to pass the second, you'll need to :ref:`manually wire the service <services-wire-specific-service>`. | ||
|
|
||
| Another solution is to add another id ``site_update_manager.superadmin`` followed by | ||
| a variable name matching the one you use when doing the injection:: |
There was a problem hiding this comment.
Suggested change
| If you want to pass the second, you'll need to :ref:`manually wire the service <services-wire-specific-service>`. | |
| Another solution is to add another id ``site_update_manager.superadmin`` followed by | |
| a variable name matching the one you use when doing the injection:: | |
| If you want to pass ``site_update_manager.superadmin``, you'll need either to :ref:`manually wire it<services-wire-specific-service>` | |
| or to create a named autowiring alias. |
(named autowiring alias should link to service_container/autowiring.rst, then, the example is not needed)
OskarStark
added a commit
to OskarStark/symfony-docs
that referenced
this pull request
Aug 14, 2023
Replaces * symfony#17051
|
Closed via #18749 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add alternative solution.