[Mailer] Add more information about sending email async #17065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2022
OskarStark
reviewed
Jul 27, 2022
|
|
||
| Thanks to this, instead of being delivered immediately, messages will be sent to | ||
| the transport to be handled later (see :ref:`messenger-worker`). | ||
| .. versionadded:: 6.2 |
There was a problem hiding this comment.
Imho this should be a warning, otherwise it gets removed in Symfony 7 docs
There was a problem hiding this comment.
Having this removed in 7.0 is a good thing.
OskarStark
reviewed
Jul 27, 2022
a39cd4f to
4fbbc16
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jul 27, 2022
…e (fabpot) This PR was merged into the 6.2 branch. Discussion ---------- [Mime] Change the way we avoid rendering an email twice | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes-ish | New feature? | yes-ish <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#17065 Trying to kill several birds with one stone here. I was not very happy with the way we ensured that emails were not renderer more than once. This solution seems easier and allows for people to render an email **before** sending it to Messenger (important when you have Doctrine entities in the context for instance) as documented in the related doc PR. Commits ------- cc3b871 [Mime] Change the way we avoid rendering an email twice
|
Related PR has been merged now. |
OskarStark
approved these changes
Jul 27, 2022
|
Thank you Fabien. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example only works as of 6.2 thanks to symfony/symfony#47075
I've written this PR because we keep having issues like symfony/symfony#44439.
So, documenting a bit more how it works internally might help people understand what to do.