Skip to content

Enable code blocks #17102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2022
Merged

Enable code blocks #17102

merged 1 commit into from
Aug 3, 2022

Conversation

alexislefebvre
Copy link
Contributor

@alexislefebvre alexislefebvre commented Aug 3, 2022 •
edited
Loading

Revert 8f250a2

Revert fb505de from #17020

Tests were broken, see that example from #17098:

Run composer config --no-plugins allow-plugins.symfony/flex true
Error: File "./composer.json" cannot be found in the current directory

In ConfigCommand.php line 206:
                                                                   
  File "./composer.json" cannot be found in the current directory  
                                                                   

config [-g|--global] [-e|--editor] [-a|--auth] [--unset] [-l|--list] [-f|--file FILE] [--absolute] [-j|--json] [-m|--merge] [--append] [--source] [--] [<setting-key> [<setting-value>...]]

Error: Process completed with exit code 1.

full output

It should not be necessary now that symfony-tools/symfony-application#14 has been merged.

@carsonbot carsonbot added this to the 5.4 milestone Aug 3, 2022
@alexislefebvre
Copy link
Contributor Author

The Code Blocks job passed succesfully. 🎉

@javiereguiluz
Copy link
Member

Thanks a lot Alexis!

@javiereguiluz javiereguiluz merged commit 253e4f4 into symfony:5.4 Aug 3, 2022
@alexislefebvre alexislefebvre deleted the enable-code-blocks branch August 3, 2022 12:55
@xabbuh xabbuh mentioned this pull request Aug 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@alexislefebvre @javiereguiluz @carsonbot