Skip to content

Fix CI by reverting #17020 #17121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Fix CI by reverting #17020 #17121

merged 1 commit into from
Aug 8, 2022

Conversation

HeahDude
Copy link
Contributor

@HeahDude HeahDude commented Aug 6, 2022

The CI is failing in #16992 because of this, see https://github.com/symfony/symfony-docs/runs/7704382531?check_suite_focus=true.

My guess if that it's now fixed upstream thanks to symfony-tools/symfony-application#14.

@HeahDude HeahDude requested a review from OskarStark as a code owner August 6, 2022 11:25
@carsonbot carsonbot added this to the 5.4 milestone Aug 6, 2022
@HeahDude HeahDude changed the base branch from 5.4 to 4.4 August 6, 2022 11:26
@xabbuh
Copy link
Member

xabbuh commented Aug 6, 2022

Are the rest of the changes from #17102 relevant too?

@HeahDude
Copy link
Contributor Author

HeahDude commented Aug 6, 2022

@xabbuh in appears there is not any commented lines in 4.4.

I've pushed the same commit in #16992 to make the CI run there and it helped me fixing some bugs that I've missed.

I'd say this is enough here.

@javiereguiluz
Copy link
Member

Thank you Jules.

@javiereguiluz javiereguiluz merged commit f36cfb5 into symfony:4.4 Aug 8, 2022
@HeahDude HeahDude deleted the fix-ci branch August 8, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants