Ensure config blocks are consistent #2 #17156
Conversation
| parameters: | ||
| env(AUTH_FILE): '../config/auth.json' | ||
| google: |
There was a problem hiding this comment.
I tried to be more generic in these examples.
|
I need to check and fix some reported errors. Status: needs work |
| </security:config> | ||
| </container> | ||
| </config> | ||
| </srv:container> |
There was a problem hiding this comment.
Does it worth dealing with this error: The child node "firewalls" at path "security" must be configured.?
A way to be consistent here would be to add a <!-- ... --> at the beginning of the <config> node, ad done already in others places.
But that wouldn't fix the error because of the required config schema, unless we expand it to something like:
<firewall name="main">
<!-- ... -->
</firewall>(same for other formats)
There was a problem hiding this comment.
I went with a consistent config without trying to fix a false positive from the checker.
|
@HeahDude do you still consider this as "needs work" or is it ready? Thanks! |
|
Yes, sadly it still needs work, and I need help, I'll see if I can get some next week at the Forum PHP when meeting old friends :). |
|
Thanks for the review @wouterj :), I'll work on it later this week. |
|
Symfony 4.4 is no longer supported ... so we should rebase this PR to 5.4 or higher. Thanks! |
|
It's sad to see that this PR stalled. @HeahDude would you have the time and energy needed to rebase it? If you don't, we totally understand it. Thanks! |
|
@javiereguiluz Yes, thanks for the ping :) |
|
Again, asking friendly to retarget on Thanks! |
|
I'm afraid we'll have to close this. If you ever find time to continue this great (in both definitions of the word) contribution, we can always reopen it. |
Continuation of #16992.