Inappropriate usage of Parameter Conversion #17200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under the section `Route Groups and Prefixes`, the action `show` seems to make usage of `Parameter Conversion` technique, though there is no reference for the `Post` class in that code snippet. I would suggest to replace the parameter `Post $post` to `string $slug` , matching the URL parameter defined above the method `show`.
OskarStark
approved these changes
Aug 18, 2022
|
Thank you Guilherme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the section
Route Groups and Prefixes, the actionshowseems to make usage ofParameter Conversiontechnique, though there is no reference for thePostclass in that code snippet.I would suggest to replace the parameter
Post $posttostring $slug, matching the URL parameter defined above the methodshow.