[Serializer] improve documentation of default_context for the serializer #17305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c50a05b to
002b0ed
Compare
|
build should get green when retrying, as the code is now merged to 6.2. |
OskarStark
reviewed
Sep 30, 2022
OskarStark
approved these changes
Sep 30, 2022
dbu
commented
Sep 30, 2022
dbu
commented
Sep 30, 2022
dbu
commented
Sep 30, 2022
|
Please also adjust the title of the PR after rebasing, thanks |
199be2e to
d0743d8
Compare
|
rebased, cleaned up and adjusted the title. regarding the linter failure: looks like thats broken in all 6.x versions: https://github.com/symfony/symfony-docs/actions/runs/3160768594/jobs/5145596113 can you fix that in 6.0 and then merge it up to 6.1 and 6.2? or we just merge with the known error... |
dbu
commented
Oct 1, 2022
|
|
||
| return static function (FrameworkConfig $framework) { | ||
| $framework->serializer() | ||
| ->defaultContext([ | ||
| AbstractObjectNormalizer::ENABLE_MAX_DEPTH => true | ||
| AbstractObjectNormalizer::ENABLE_MAX_DEPTH => true, | ||
| YamlEncoder::YAML_INDENTATION => 2, |
There was a problem hiding this comment.
there is a build failure about this, but i don't understand it.
OskarStark
reviewed
Oct 1, 2022
d0743d8 to
852aa11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additional info for #17310
fix #17306
the code example will only work once symfony/symfony#47243 is merged