Skip to content

[Uid] Add documentation for Uuid 7 and 8 #17315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2022
Merged

[Uid] Add documentation for Uuid 7 and 8 #17315

merged 1 commit into from
Oct 3, 2022

Conversation

JohJohan
Copy link
Contributor

@JohJohan JohJohan commented Oct 1, 2022 •
edited by wouterj
Loading

Adds documentation for Uuid 7 and 8

Fixes #17258

@JohJohan JohJohan requested a review from xabbuh as a code owner October 1, 2022 11:47
@carsonbot carsonbot added this to the 6.2 milestone Oct 1, 2022
@JohJohan
Copy link
Contributor Author

JohJohan commented Oct 1, 2022

Let me know if it is okay to use text from https://www.ietf.org/archive/id/draft-peabody-dispatch-new-uuid-format-04.html#name-uuid-version-7 as well as linking to that source

@OskarStark OskarStark changed the title [UUID] 17258 Add documentation for Uuid 7 and 8 [UUID] Add documentation for Uuid 7 and 8 Oct 1, 2022
@OskarStark OskarStark changed the title [UUID] Add documentation for Uuid 7 and 8 [Uid] Add documentation for Uuid 7 and 8 Oct 1, 2022
OskarStark
OskarStark reviewed Oct 1, 2022
View reviewed changes
@JohJohan JohJohan requested review from OskarStark and removed request for xabbuh October 2, 2022 07:30
OskarStark
OskarStark reviewed Oct 2, 2022
View reviewed changes
OskarStark
OskarStark reviewed Oct 2, 2022
View reviewed changes
OskarStark
OskarStark reviewed Oct 2, 2022
View reviewed changes
OskarStark
OskarStark reviewed Oct 2, 2022
View reviewed changes
OskarStark
OskarStark reviewed Oct 2, 2022
View reviewed changes
@carsonbot carsonbot changed the title [Uid] Add documentation for Uuid 7 and 8 Add documentation for Uuid 7 and 8 Oct 2, 2022
OskarStark
OskarStark reviewed Oct 2, 2022
View reviewed changes
@OskarStark
Copy link
Contributor

Just some more line breaking stuff, afterwards good to go

@JohJohan
Copy link
Contributor Author

JohJohan commented Oct 2, 2022

@OskarStark thanks for the review and suggestions!

HeahDude
HeahDude suggested changes Oct 2, 2022
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that PR!

@OskarStark OskarStark requested a review from HeahDude October 3, 2022 07:15
HeahDude
HeahDude approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very last small comment from me. Looks good!

@carsonbot carsonbot changed the title Add documentation for Uuid 7 and 8 [Uid] Add documentation for Uuid 7 and 8 Oct 3, 2022
@javiereguiluz javiereguiluz merged commit d30127a into symfony:6.2 Oct 3, 2022
@javiereguiluz
Copy link
Member

Thank you Johan!

@JohJohan JohJohan deleted the 17258 branch October 3, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@HeahDude HeahDude HeahDude approved these changes

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees
No one assigned
Labels
Status: Reviewed Uid
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

[Uid] Add UuidV7 and UuidV8
5 participants
@JohJohan @OskarStark @javiereguiluz @HeahDude @carsonbot