Update cookbook/templating/twig_extension.rst #1745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the namespace scope to global for \Twig_Extension and \Twig_Filter_Method.
|
This is useless as there is use statements for these 2 classes. However, it is true that using the FQCN would follow the Symfony2 CS in a better way. But in such case, the unused use statements should be removed |
|
@stof can you refer to the standard where this is described? I can't find it. |
|
@wouterj I'm not sure this is written in the CS documentation. But this doc starts by saying |
|
@stof yes, you're right :) |
weaverryan
added a commit
that referenced
this pull request
Oct 7, 2012
|
Hi Chris and guys! I've patched this into the 2.0 branch at sha: dea7e7b and removed the unnecessary use statements. Thanks for the conversation on this beforehand - I had never really thought which way was the standard, but you're correct that it's done internally like this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the namespace scope to global for \Twig_Extension and \Twig_Filter_Method.