[Validator] Removal code-block php-annotation #17468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Maxime. |
xabbuh
reviewed
Nov 28, 2022
| @@ -38,54 +38,27 @@ use it as an annotation/attribute in other classes. | |||
|
|
|||
| The ``#[HasNamedArguments]`` attribute was introduced in Symfony 6.1. | |||
|
|
|||
| You can use ``#[HasNamedArguments]`` or ``getRequiredOptions()`` to make some constraint options required: | |||
| You can use ``#[HasNamedArguments]`` or ``getRequiredOptions()`` to make some constraint options required:: | |||
There was a problem hiding this comment.
not sure if we really should mention this method any longer if we do not have an example for it anymore
There was a problem hiding this comment.
I agree with you that this method is no longer used. Thanks
I have created a PR #17476
OskarStark
added a commit
that referenced
this pull request
Nov 30, 2022
…the example (mdoutreluingne) This PR was merged into the 6.1 branch. Discussion ---------- [Validator] `getRequiredOptions()` is no longer used in the example Following #17468 I forgot to delete the method `getRequiredOptions()` as it is no longer used in the example and I have also removed the ``@Annotation`` because it was also no longer used in the example. Commits ------- 858cabc [Validator] Remove annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #17223