Modernize Web Server Configuration article (remove obsolete Apache examples, add Caddy) #17597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 20, 2022
dunglas
reviewed
Dec 21, 2022
setup/web_server_configuration.rst
Outdated
Comment on lines
193
to
221
| .. code-block:: raw | ||
|
|
||
| # /etc/caddy/Caddyfile | ||
| domain.tld, www.domain.tld { | ||
| root * /var/www/project/public | ||
|
|
||
| # serve files directly if they can be found (e.g. CSS or JS files in public/) | ||
| encode zstd gzip | ||
| file_server | ||
|
|
||
|
|
||
| # otherwise, use PHP-FPM (replace "unix//var/..." with "127.0.0.1:9000" when using TCP) | ||
| php_fastcgi unix//var/run/php/php7.4-fpm.sock { | ||
| # optionally set the value of the environment variables used in the application | ||
| # env APP_ENV "prod" | ||
| # env APP_SECRET "<app-secret-id>" | ||
| # env DATABASE_URL "mysql://db_user:db_pass@host:3306/db_name" | ||
| } | ||
|
|
||
| # return 404 for all other php files not matching the front controller | ||
| # this prevents access to other php files you don't want to be accessible. | ||
| @phpFile { | ||
| path *.php* | ||
| } | ||
| error @phpFile "Not found" 404 | ||
| } |
There was a problem hiding this comment.
Here is a slightly simpler proposal based on API Platform's Caddyfile:
Suggested change
| .. code-block:: raw | |
| # /etc/caddy/Caddyfile | |
| domain.tld, www.domain.tld { | |
| root * /var/www/project/public | |
| # serve files directly if they can be found (e.g. CSS or JS files in public/) | |
| encode zstd gzip | |
| file_server | |
| # otherwise, use PHP-FPM (replace "unix//var/..." with "127.0.0.1:9000" when using TCP) | |
| php_fastcgi unix//var/run/php/php7.4-fpm.sock { | |
| # optionally set the value of the environment variables used in the application | |
| # env APP_ENV "prod" | |
| # env APP_SECRET "<app-secret-id>" | |
| # env DATABASE_URL "mysql://db_user:db_pass@host:3306/db_name" | |
| } | |
| # return 404 for all other php files not matching the front controller | |
| # this prevents access to other php files you don't want to be accessible. | |
| @phpFile { | |
| path *.php* | |
| } | |
| error @phpFile "Not found" 404 | |
| } | |
| .. code-block:: raw | |
| # /etc/caddy/Caddyfile | |
| example.com, www.example.com | |
| log | |
| route { | |
| root * /var/www/project/public | |
| php_fastcgi unix//var/run/php/php8.2-fpm.sock | |
| encode zstd gzip | |
| file_server | |
| } |
There was a problem hiding this comment.
To keep consistency with the Apache and Nginx examples, I've decided to keep the longer format.
thePanz
reviewed
Dec 31, 2022
|
Wouter, will you find some time to finish this? If you can't, I can try to merge this "as is", but including the fixes suggested by Kévin. Thanks! |
94noni
reviewed
May 27, 2023
thePanz
approved these changes
Aug 3, 2023
|
Thank you Wouter and thanks to reviewers too! |
|
That is awesome to have this in symfony doc now. Thx all 👍 |
|
What's the reason you removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues #16104 (which removed old Apache information that advocates bad practices) and fixes #17471 by adding a working Caddy config example.
I've removed most of the Apache 2 version information, we were talking about 2.4 and 2.10, but even Debian oldoldstable (the really long LTS version of Debian) comes with 2.25 already.
I've kept using PHP 7.4 - something that we might want to change when merging up to 6.0. This is done to make the example in the article truely copy-pastable, PHP 7.4 is the current PHP version on the latest Debian version.