[Workflow] Do not talk about registry #17878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not recommended since symfony/symfony#46000
OskarStark
reviewed
Feb 7, 2023
| @@ -103,7 +82,6 @@ method to initialize the object property:: | |||
|
|
|||
| // ... | |||
| $blogPost = new BlogPost(); | |||
| $workflow = $registry->get($blogPost); | |||
|
|
|||
| // initiate workflow | |||
| $workflow->getMarking($blogPost); | |||
There was a problem hiding this comment.
$workflow is not defined anymore
| // ... | ||
| // Consider that $blogPost is in place "draft" by default | ||
| $blogPost = new BlogPost(); | ||
| $workflow = $registry->get($blogPost); |
There was a problem hiding this comment.
$workflow is not defined anymore
There was a problem hiding this comment.
Yes, but shouldn't we show an example of injecting the workflow into a controller action or a service? There is no example for this, right?
There was a problem hiding this comment.
Oh I think it's mentioned here:
Read more about the usage of the :doc:`Workflow component </workflow>` inside a Symfony application.
|
Thanks Grégoire. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not recommended since symfony/symfony#46000