[Mailer] add more info for debugging #17950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Mar 11, 2023
mailer.rst
Outdated
| @@ -641,6 +641,12 @@ provides access to the original message (``getOriginalMessage()``) and to some | |||
| debug information (``getDebug()``) such as the HTTP calls done by the HTTP | |||
| transports, which is useful to debug errors. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| You will need to replace the typehint :class:`Symfony\\Component\\Mailer\\MailerInterface` | |||
There was a problem hiding this comment.
Suggested change
| You will need to replace the typehint :class:`Symfony\\Component\\Mailer\\MailerInterface` | |
| You will need to replace :class:`Symfony\\Component\\Mailer\\MailerInterface` |
OskarStark
reviewed
Mar 11, 2023
mailer.rst
Outdated
| .. note:: | ||
|
|
||
| You will need to replace the typehint :class:`Symfony\\Component\\Mailer\\MailerInterface` | ||
| :class:`Symfony\\Component\\Mailer\\Transport\\TransportInterface` to have |
There was a problem hiding this comment.
Suggested change
| :class:`Symfony\\Component\\Mailer\\Transport\\TransportInterface` to have | |
| with :class:`Symfony\\Component\\Mailer\\Transport\\TransportInterface` to have |
|
Open to finish this PR? |
|
@OskarStark thx for reviewing, here you are PR updated :) |
OskarStark
approved these changes
Mar 11, 2023
|
This is already the case in 5.4 branch, isn't it? |
|
Thanks Antoine! We merged this in 5.4 branch and up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I did not understand this section of getDebug until I navigate the code and see the swap to do with
MailerInterface$a = $this->mailer->send($email); // $a is null
TransportInterface$a = $this->mailer->send($email); // $a is SentMessage