Skip to content

Add note about custom port being ignored by specific mailer transport DSN #18118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

sanderdlm
Copy link

See symfony/symfony#49768

Seems like there has been some confusion about this:

People start with the default they're given by the docs, e.g. sendgrid+smtp and then try to append :<port> to configure it, which doesn't work.

As far as I know, the official recommendation is to use the regular smtp transport instead when using custom config: symfony/symfony#36224 (comment)

@carsonbot carsonbot added this to the 6.3 milestone Mar 25, 2023
fabpot added a commit to symfony/symfony that referenced this pull request Mar 25, 2023
This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Mailer] Update default Mailgun port

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT

Alternative to #49768. Instead of passing the port from the DSN, update the default to 587, which is recommended by Mailgun.

I've also opened a docs PR to clarify that specific bridge DSNs ignore the port: symfony/symfony-docs#18118

Commits
-------

05e9be7 [Mailer] Update default Mailgun port
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be merged in 5.4

@fabpot fabpot changed the base branch from 6.3 to 5.4 March 25, 2023 08:58
@fabpot fabpot requested a review from xabbuh as a code owner March 25, 2023 08:58
@fabpot
Copy link
Member

fabpot commented Mar 25, 2023

Thank you @dreadnip.

@fabpot fabpot force-pushed the specific-dsn-port-notice branch from 6d3c03a to b39027f Compare March 25, 2023 08:58
@fabpot fabpot merged commit d2eccda into symfony:5.4 Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants