Skip to content

[DependencyInjection] Document ServiceConfigurator remove method #18178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alamirault
Copy link
Contributor

Continue work started by @94noni in #17098

Fix #14854

@alamirault alamirault force-pushed the feature/dependency-injection-remove branch from 6073c24 to 3d9dfe6 Compare April 7, 2023 15:12
@OskarStark OskarStark changed the title [DependencyInjection] Document ServiceConfigurator remove method [DependencyInjection] Document ServiceConfigurator remove method Apr 8, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho can a user reach this page? Is there an include? I can't find one 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought, it's dynamically added to the menu or in Learn more ?

(service_container/calls.rst has no ref but it's in "Learn more")

However, if you see a better place, we can move it

@javiereguiluz
Copy link
Member

Antoine, thanks for this contribution. However, a few years ago we decided to no longer use short pages in the docs (they may look convenient to document things ... but they are confusing and cumbersome for readers, which are continuously moving from one page to another).

Removing a service from the container looks like a basic feature of it, so maybe we could move this to a new section in the main /service_container.rst article. Thanks.

@javiereguiluz javiereguiluz added this to the 5.4 milestone Jun 9, 2023
@javiereguiluz javiereguiluz merged commit 8ae0222 into symfony:5.4 Jun 9, 2023
@javiereguiluz
Copy link
Member

This is now merged! While merging, I did the change I mentioned earlier: remove the new short article and move its contents to the main DI article. Thanks.

@alamirault
Copy link
Contributor Author

Thank you Javier !

@alamirault alamirault deleted the feature/dependency-injection-remove branch June 9, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DependencyInjection] Add a remove() method to the PHP configurator
4 participants