Skip to content

[Form] Add some basic docs for Twig Form field helpers #18191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2023

Conversation

jmsche
Copy link
Contributor

@jmsche jmsche commented Apr 11, 2023

Closes #14308

Refers to the feature added in symfony/symfony#38307

Hi,

So these Twig helpers have been added for a long time now (2+ years) but unfortunately it's still undocumented.

As a "quick fix", I took the liberty to "steal" the text + example from the related blog post so they will at least be referenced in the docs.

@jmsche
Copy link
Contributor Author

jmsche commented Apr 11, 2023

CI does not know about these "new" functions, a PR was created to address this issue on the corresponding repository: symfony-tools/code-block-checker#48

@jmsche jmsche closed this Apr 14, 2023
@jmsche jmsche reopened this Apr 14, 2023
@OskarStark OskarStark added this to the 5.4 milestone Apr 14, 2023
@jmsche jmsche changed the base branch from 6.2 to 5.4 April 14, 2023 07:00
@carsonbot carsonbot changed the title Add some basic docs for Twig Form field helpers [Form] Add some basic docs for Twig Form field helpers May 4, 2023
@javiereguiluz javiereguiluz merged commit f47dced into symfony:5.4 May 4, 2023
@javiereguiluz
Copy link
Member

It was really sad to not mention these form helpers in docs yet, so let's merge this. Thanks a lot @jmsche!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants