Security cookbook pass #1825
Security cookbook pass #1825
Conversation
| @@ -5,9 +5,9 @@ How to force HTTPS or HTTP for Different URLs | |||
| ============================================= | |||
|
|
|||
| You can force areas of your site to use the ``HTTPS`` protocol in the security | |||
| config. This is done through the ``access_control`` rules using the ``requires_channel`` | |||
| config. This is done through the ``access_control`` rules, using the ``requires_channel`` | |||
There was a problem hiding this comment.
This comma is not necessary.
There was a problem hiding this comment.
I'm not sure what was meant here: who is using the requires_channel? The developer who writes the code (which made me add this comma), or is it the access_control rules? But maybe it does not even matter. What do you think?
If you really want me to remove this comma, how should I do this? Should I add a reverting commit to this pull request? Or make another pull request?
There was a problem hiding this comment.
I'm not really sure, but I think that doing an stop there is odd. That's why I suggest that.
If you revert you'll lose the other change, so simple do a different PR.
There was a problem hiding this comment.
I'm not really sure, but I think that doing an stop there is odd.
It feels less odd to me without the comma, so if you're not sure, I propose we let @weaverryan decide, I believe he's a native english speaker.
There was a problem hiding this comment.
It is actually better without the comma - it's just one straight thought, similar to I got to the hotel using a taxi.
But, the vast majority of what you had here is perfect.
Cheers!
There was a problem hiding this comment.
@Nomack84 : looks like you were right :) !
@weaverryan : I trust I don't have anything do to, it looks like you managed apply the PR without this commit...
|
Hi guys! Lot's of nice changes here. I've merged them in and made a few small tweaks. Thanks - these small PR's a so great to keeping the docs high quality! |
A couple of corrections, please read carefully, I'm not dead sure about all of them.