Skip to content

[Routing] Added a note about defining route requirements in the container #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Routing] Added a note about defining route requirements in the container #1827

wants to merge 4 commits into from

Conversation

alvarezmario
Copy link
Contributor

Yesterday I was searching how to do this and I can't find nothing in the docs. Thanks @Tobion

@@ -612,6 +612,16 @@ the regular expression ``(en|fr)``.
| /es | *won't match this route* |
+-----+--------------------------+

.. sidebar:: Requirements defined in the container

If for some reason you need to define some configurable requirements,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not good in English grammar, but I think this should be:

If, for some reason, you need to define some configurable requirements,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me neither, I'm Cuban and I speak Spanish. Probably you are right. Thanks.

@alvarezmario
Copy link
Contributor Author

@wouterj What do you think now?

@stof
Copy link
Member

stof commented Oct 18, 2012

I think this should be a cookbook article, to be easier to find (as it would be linked from the index page)

@alvarezmario
Copy link
Contributor Author

@stof Don't you think is to little content for a cookbook article? If not, the I'll be glad to do it.

.. code-block:: yaml

contact:
pattern: /_locale/contact
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be /{_locale}/contact (same for xml and php format)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it was a typo. Fixed!

@Tobion
Copy link
Contributor

Tobion commented Oct 19, 2012

This feature is only available since 2.1. So this PR should be done on the 2.1 branch.

@Tobion
Copy link
Contributor

Tobion commented Oct 19, 2012

Please also mention that you can use these kernel params in the pattern for static text like /%configurable%.
And you can excape such a parameter by doubling the %, e.g. /%%idontexist%%.

@alvarezmario
Copy link
Contributor Author

@Tobion The make this PR againt 2.1 branch, should I close this and reopen again, or there is another way?

@Tobion
Copy link
Contributor

Tobion commented Oct 19, 2012

You need to open a new pr.

@alvarezmario
Copy link
Contributor Author

Ok. Thanks for the tip!

2012/10/19 Tobias Schultze notifications@github.com

You need to open a new pr.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1827#issuecomment-9597980.

@alvarezmario
Copy link
Contributor Author

See #1832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants