[Components][DomCrawler] Remove protected method getRawUri() #1837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getRawUri() is a protected method, so it's not accesible and shouldn't be listed on the docs https://github.com/symfony/symfony/blob/2.0/src/Symfony/Component/DomCrawler/Link.php#L137 The method it's still protected on master, so it applies for all doc branches: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DomCrawler/Link.php#L137 Also moved the comment to a "note" block so it's a bit more prominent
weaverryan
added a commit
that referenced
this pull request
Oct 23, 2012
[Components][DomCrawler] Remove protected method getRawUri()
|
Hey Albert! Ah yes, you're absolutely right! Nice fix, I like the way you've formatted things. Thanks for the fix and the perfect PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getRawUri() is a protected method, so it's not accesible and shouldn't be listed on the docs
https://github.com/symfony/symfony/blob/2.0/src/Symfony/Component/DomCrawler/Link.php#L137
The method it's still protected on master, so it applies to all doc branches:
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DomCrawler/Link.php#L137
Also moved brief explanation of the method from the block to a "note" block so it's a bit more prominent