Skip to content

[Mailer] Improve DSN formats table #18382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

thimisc
Copy link
Contributor

@thimisc thimisc commented Jun 7, 2023

This PR try to improve readibility of DSN formats table which displays horizontally too long and under the right sidebar on small screens when reading from symfony.com.

I changed table layout so it displays only two columns instead of four (see captures below).

Please keep in mind that there is a pending PR for renaming Sendinblue to Brevo (#18359) so this PR should be updated accordingly.

broken_layout

fixed_layout

@javiereguiluz
Copy link
Member

Thibault, what a great first contribution! And thanks for the detailed description and screenshots!

Congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz changed the base branch from 6.3 to 6.2 June 8, 2023 15:16
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner June 8, 2023 15:16
@javiereguiluz javiereguiluz force-pushed the improve-dsn-formats-table branch from bbda5c3 to cc46c48 Compare June 8, 2023 15:16
@javiereguiluz javiereguiluz merged commit 2e73d09 into symfony:6.2 Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants