Skip to content

[Translation] Deprecate the PhpExtractor #18515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[Translation] Deprecate the PhpExtractor #18515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions reference/dic_tags.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,9 +1071,22 @@ file

When executing the ``translation:extract`` command, it uses extractors to
extract translation messages from a file. By default, the Symfony Framework
has a :class:`Symfony\\Bridge\\Twig\\Translation\\TwigExtractor` and a
:class:`Symfony\\Component\\Translation\\Extractor\\PhpExtractor`, which
help to find and extract translation keys from Twig templates and PHP files.
has a :class:`Symfony\\Bridge\\Twig\\Translation\\TwigExtractor` and a PHP
extractor to find and extract translation keys from Twig templates and PHP files.

Symfony includes two PHP extractors: :class:`Symfony\\Component\\Translation\\Extractor\\PhpExtractor`
and :class:`Symfony\\Component\\Translation\\Extractor\\PhpAstExtractor`. The
first one is simple but doesn't require to install any packages; the second one
is much more advanced, but requires to install this dependency in your project:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more advanced

I think we can tell at least it supports latest PHP8 syntax and maybe better performance (but I don't know if there is en benchmark)

From PR symfony/symfony#46161

to support various syntax, especially PHP8 new syntax (named arguments for example)

In order to make this new extractor sustainable, performant and maintainable, it must be based on AST

WDYT ?

Copy link
Member Author

@javiereguiluz javiereguiluz Jul 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this. If we mention "PHP 8 features" ... that will be outdated "soon" when new PHP versions release.

Also, we don't really need to sell the new extractor so people choose it. In next Symfony versions they can only use the AST extractor, so they can't really make a decision, just comply.


.. code-block:: terminal

$ composer require nikic/php-parser

.. deprecated:: 6.2

The ``PhpExtractor`` class is deprecated since Symfony 6.2. The ``PhpAstExtractor``
class will be the only PHP extractor available starting from Symfony 7.0.

You can create your own extractor by creating a class that implements
:class:`Symfony\\Component\\Translation\\Extractor\\ExtractorInterface`
Expand Down