I don't think we need to remove %app.root_dir%. The docs talks about using parameters inside a config file and it talks about what the root_dir is.

It maybe is a good idea to create a .. note:: block which talks short about this.

The parameter is still there I've just renamed it ;)

Hi Bilal!

Merged! I did change the parameter back to kernel.root_dir - I think that there's no harm if this "meaningless" parameter is shown to component users, but at least it is meaningful to component users. app may be slightly more descriptive than kernel, but I think both are clear. If component users think that there is some built-in significance to this component, then we should explain it (but I don't know if that's actually an issue).

Thanks for the fix and bringing up a good point (about the parameter) that I hadn't thought about before!

Hi Ryan,

Thanks for taking the time to explain your decision, I get your point about framework users but actually I think the opposite.

Personnaly I looked at this dependency injection doc for 2 reasons, the first one is of course to know how I can get this working on a regular PHP project not using the full stack framework, then it was also an opportunity to understand how the full-stack framework works, for example here if I had saw an %app.root_dir% parameter, it would make me think about %kernel.root_dir% as they're similar, and I would guess : "Oh, the kernel component probably uses this component too, and it defines a container builder with %kernel.root_dir% parameter instead of %app.root_dir%".

But this can not be the case anymore if components docs are not reduced to their minimal explanations.

Sorry for bothering you with this parameter as it's not a big deal but the point behind this is important imo.