[DependencyInjection] Update kernel.reset explanation #18635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reference/dic_tags.rst
Outdated
| @@ -711,7 +711,7 @@ kernel.reset | |||
|
|
|||
| **Purpose**: Clean up services between requests | |||
|
|
|||
| During the ``kernel.terminate`` event, Symfony looks for any service tagged | |||
| When it's not the first Request, Symfony looks for any service tagged | |||
There was a problem hiding this comment.
Yes, this is a bit hard to understand. What about being a bit more explicit to also mention main/sub requests, etc.
Proposal:
In all main requests (not :ref:`sub-requests <http-kernel-sub-requests>`) except
the first one, Symfony looks for any service tagged with the ``kernel.reset`` tag
to reinitialize their state. This is done by calling to the method whose name is
configured in the ``method`` argument of the tag.There was a problem hiding this comment.
I applied your suggestion 😃 Thanks
c3f1eec to
a8803e2
Compare
|
Thanks Antoine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #16806
Change was done in this PR symfony/symfony#24709
I'm open for better wording 😄