Remove min max length references 2.1 #1864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 29, 2012 11:20
Conflicts: reference/constraints/Collection.rst
weaverryan
added a commit
that referenced
this pull request
Nov 16, 2012
weaverryan
added a commit
that referenced
this pull request
Nov 16, 2012
…nd marking them as deprecated
|
Hi Grégoire! Great PR - we obviously hadn't taken care of these deprecated constraints yet in the docs, so this is really good. I also added a few small extra fixes and marked the constraints themselves as deprecated. If you see anything else wrong, let me know! Thanks! |
|
Hi Ryan! Glad you enjoyed this PR and extended it to numbers! Be sure I'll make other PRs if I find anything else wrong! Have a good day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MinLength and MaxLength are deprecated. Do not use them as examples.