[FrameworkBundle] Configuration : Fix !php/const syntax in yaml #18761
Conversation
|
The CI seems to be in error because in the code block checker, the parsing of Yaml is done without the Yaml::PARSE_CONSTANT flag, unlike what is done when parsing Yaml files in the Configuration Loader. In code-block-checker : In Symfony YamlLoader : |
|
I just submit a small PR in code-block-checker to fix the problem: symfony-tools/code-block-checker#49 |
|
I released the code block checker 0.3.0, can you please rebase your PR, to verify the CI is back green? Thanks |
Quoted scalar is not evaluated
be318ea to
4121f05
Compare
|
I've just done it, everything seems to be fine now. |
|
Pierre, this was a very good catch and a great first contribution. Thanks a lot for your patience during the review and for fixing the Symfony Tools issue too. Thanks also to reviewers. Finally, congrats on your first Symfony Docs contribution 🎉 |
Hello,
I would like to suggest a correction for the FrameworkBundle configuration documentation. In a configuration example, the Yaml syntax to use the value of a PHP constant as a key is incorrect. Indeed, in Symfony's Yaml parser source code, only unquoted scalars are evaluated. Therefore, the configuration key should not be enclosed in quotes for the example to work.
Please feel free to question me if you need any further information.