Added missing dot in property path assembly. #1885
Conversation
| @@ -217,7 +217,7 @@ With this, the validator ``isValid()`` method gets an object as its first argume | |||
| { | |||
| if ($protocol->getFoo() != $protocol->getBar()) { | |||
|
|
|||
| $propertyPath = $this->context->getPropertyPath() . 'foo'; | |||
| $propertyPath = $this->context->getPropertyPath() . '.foo'; | |||
There was a problem hiding this comment.
It's not your foult, but can you please remove the space around the dot operator?
There was a problem hiding this comment.
Sure, it's gone.
~~I have a noob question though: I tried to stick closely to the contribution docs but couldn't find the described to link to change the base branch back to @2.0. I somehow managed to change the branch after some fiddling around but that left a PR for the master branch which I closed directly. I guess that's not how it's meant to be done so maybe the contribution docs are outdated or a little fuzzy? Chances are of course that I am simply blind… ;-)
Thanks in advance.~~
Edit: Got it. Turned out to be a classical RTFM. Never mind.
Cheers
Am 03.11.2012 um 23:02 schrieb Wouter J notifications@github.com:
In cookbook/validation/custom_constraint.rst:
@@ -217,7 +217,7 @@ With this, the validator
isValid()method gets an object as its first argume
{
if ($protocol->getFoo() != $protocol->getBar()) {
$propertyPath = $this->context->getPropertyPath() . 'foo';$propertyPath = $this->context->getPropertyPath() . '.foo';—
Reply to this email directly or view it on GitHub.
…ty_path Added missing dot in property path assembly.
|
Hi Björn! Great fix and perfect PR! Thanks! |
No description provided.