Minor Corrections and Additional check to prevent unnecessary exception #1905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing options parameter
Change services class path to match namespace declared in Extension class
Removing unused use statement
Adding a check to ensure a PropertyPath object is never created with null data causing an exception.
Removing deprecated use of FormView set method
weaverryan
added a commit
that referenced
this pull request
Nov 22, 2012
|
Hi Kevin! Ah, you have a couple of good changes here - some apply also to the 2.0 branch, but some only to the 2.1 branch :). I've patched your commits into the 2.1 branch at the following commits: I also backported a few changes to 2.0 at sha: 58f1aa2 Thanks! |
weaverryan
added a commit
that referenced
this pull request
Nov 22, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.