Add info about feature freeze period #19110
Conversation
|
Thank you, @OskarStark!
|
Not sure, as this is not a hard, more a soft deadline, lets ask @nicolas-grekas and @fabpot
Not sure it's worth, but possibly yes. But once done, @carsonbot could use that information |
|
We already document this as the "stabilization" period of two months here: https://symfony.com/doc/current/contributing/community/releases.html#development |
|
I agree, but this does not really explain what that mean for the contributor |
contributing/code/pull_requests.rst
Outdated
| @@ -147,6 +147,15 @@ work: | |||
| for the ``5.4`` branch, the PR will also be applied by the core team on | |||
| all the ``6.x`` branches that are still maintained. | |||
|
|
|||
| .. warning:: | |||
There was a problem hiding this comment.
isnt "info" enough?
"warning" seem to strong and devs may be not opening new PR :s
what about:
during a short period of time prior to the release of a new symfony major version, the symfony repository
is feature freeze. Your pull requests are still more than welcome nonetheless they must target the next major version
something like that ^^
contributing/code/pull_requests.rst
Outdated
| @@ -147,6 +147,15 @@ work: | |||
| for the ``5.4`` branch, the PR will also be applied by the core team on | |||
| all the ``6.x`` branches that are still maintained. | |||
|
|
|||
| .. warning:: | |||
|
|
|||
| For a short timeframe before a new major version is released, we are in a | |||
There was a problem hiding this comment.
Is it only before a major version? I have the feeling that I already saw some feature freeze for minor version to stabilize the whole thing, but I may be wrong 🤔
|
I don't think that this is needed as this is already described here: https://symfony.com/doc/current/contributing/community/releases.html#development Maybe adding a link to this paragraph would be enough. |
|
I agree that we should not duplicate the release cycle documentation, but I like mentioning it on this page. It's common to see contributors confused what they should do with their PR during this phase. What about replacing the strong warning with a more subtle paragraph like: During the :ref:`stabilization phase <contributing-release-development>`, the development branch is in
feature freeze. Please help the community prepare for the new version release. If you want to submit a
new feature pull request, you should target the next version. For example, if ``6.3`` reached feature
freeze, new features should target ``6.4``. If the ``6.4`` branch does not yet exists, target ``6.3``
and rebase your pull requests once the branch is created.(second sentence may be removed, I can't help myself pushing everyone to not focus on writing new features during these 2 months 😛 ) |
That works for me |
7dd1252 to
5f92370
Compare
|
Thanks @wouterj, I used your proposal |
b2d3433 to
809f169
Compare
Follows