Skip to content

[Webhook] Added component documentation for use in combination with Mailer #19249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2023
Merged

[Webhook] Added component documentation for use in combination with Mailer #19249

merged 1 commit into from
Dec 12, 2023

Conversation

TimoBakx
Copy link
Member

@TimoBakx TimoBakx commented Dec 9, 2023 •
edited by OskarStark
Loading

@carsonbot carsonbot added this to the 6.4 milestone Dec 9, 2023
dsdeboer
dsdeboer approved these changes Dec 9, 2023
View reviewed changes
Copy link

@dsdeboer dsdeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@OskarStark
Copy link
Contributor

A personal big big thank you for driving this forward. Thank you Timo 🙏

@OskarStark OskarStark requested a review from fabpot December 9, 2023 15:59
@OskarStark OskarStark mentioned this pull request Dec 9, 2023
Closed
@OskarStark OskarStark modified the milestones: 6.4, 6.3 Dec 9, 2023
@OskarStark
Copy link
Contributor

Please rebase on 6.3, thanks

@alexandre-daubois
Copy link
Member

Congrats on this new version 🥳

@TimoBakx TimoBakx changed the base branch from 6.4 to 6.3 December 9, 2023 21:04
@TimoBakx
Copy link
Member Author

TimoBakx commented Dec 9, 2023 •
edited
Loading

@OskarStark thank you for reminding me.

The code block check fails due to Webhook not being installed in the test application (symfony-tools/symfony-application). Should I add it there?

MrYamous
MrYamous reviewed Dec 9, 2023
View reviewed changes
@MrYamous
Copy link
Contributor

MrYamous commented Dec 9, 2023

I am glad to see some news for this component documentation, congratulations

@TimoBakx
Copy link
Member Author

Thank you @MrYamous and @OskarStark for the feedback. I've updated everything accordingly.

MrYamous
MrYamous reviewed Dec 10, 2023
View reviewed changes
@OskarStark OskarStark mentioned this pull request Dec 11, 2023
Merged
TimoBakx
TimoBakx commented Dec 11, 2023
View reviewed changes
@OskarStark
Copy link
Contributor

Can you please rebase? I fixed the Build error

OskarStark added a commit that referenced this pull request Dec 12, 2023
@OskarStark
minor #19263 [Mailer] Mention webhook support in Mailer bridge overvi…
d68bf61 
…ew (OskarStark)

This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Mailer] Mention webhook support in Mailer bridge overview

Refs
* #19249

cc `@MrYamous` `@TimoBakx`

What do you think about this?

Do we have other bridges which supporting webhook since 6.3 ? 🤔

Commits
-------

d8c2c3b [Mailer] Mention webhook support in Mailer bridge overview
@TimoBakx
Copy link
Member Author

@OskarStark Rebased & squashed.

@OskarStark
Copy link
Contributor

Big big thank you!

@OskarStark OskarStark merged commit 0b58658 into symfony:6.3 Dec 12, 2023
@OskarStark
Copy link
Contributor

Maybe someone can provide more infos about which bridges support webhooks in mailer.rst starting from 6.4 branch

@alexandre-daubois
Copy link
Member

Congrats! 😃

I'm looking at bridges 👍

@TimoBakx
Copy link
Member Author

Maybe someone can provide more infos about which bridges support webhooks in mailer.rst starting from 6.4 branch

Working in the PRs for those. :)

@OskarStark
Copy link
Contributor

Only one please :-D

@TimoBakx TimoBakx mentioned this pull request Dec 12, 2023
Merged
@TimoBakx
Copy link
Member Author

Only one please :-D

Sorry, I was too fast. >_<

OskarStark added a commit that referenced this pull request Dec 12, 2023
@OskarStark
minor #19267 [Webhook] Added Sendgrid's webhook support (added in 6.4…
d8d2df9 
…) (TimoBakx)

This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[Webhook] Added Sendgrid's webhook support (added in 6.4)

Follow-up of #19249

Commits
-------

b8d08cb [Webhook] Added Sendgrid's webhook support (added in 6.4)
@TimoBakx TimoBakx deleted the webhook branch December 12, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrYamous MrYamous MrYamous left review comments

@OskarStark OskarStark OskarStark approved these changes

@dsdeboer dsdeboer dsdeboer approved these changes

@fabpot fabpot Awaiting requested review from fabpot

Assignees
No one assigned
Labels
Hack Day Status: Reviewed Webhook
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
6 participants
@TimoBakx @OskarStark @alexandre-daubois @MrYamous @dsdeboer @carsonbot