Changed wrong argument names #1950
Conversation
As twig will support named arguments soon
|
Hey! Even though we're making this change because Twig will soon support named arguments, I think the changes to the form twig reference should be made to the 2.0 branch (no reason to have unnecessary inconsistency between the branches). What do you think? If you agree, then you can reverse the form reference on this PR and make another to 2.0 with those changes. Thanks! |
|
I agree with you (honestly I think I rebased my PR on 2.0 but forgot to change it on github...). I think you can cherrypick this easy in the 2.0 branch as there aren't any differences between |
|
@wouterj can you rebase this against 2.0 again? I think we may have made some formatting changes to this doc, and now it's not patching cleanly (and so the whole patch fails). Thanks! |
|
@weaverryan I will do. |
|
PR created: #1953 |
As twig will support named arguments soon.
I am not really sure about the examples, as I don't use Symfony on a regular base, but I think I will change this to
viewtoo?