Skip to content

Fixed a typo #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed a typo #1960

wants to merge 1 commit into from

Conversation

DenisGorbachev
Copy link

No description provided.

@@ -252,7 +252,7 @@ Creating a Compiler Pass
------------------------

You can also create and register your own compiler passes with the container.
To create a compiler pass it needs to implements the :class:`Symfony\\Component\\DependencyInjection\\Compiler\\CompilerPassInterface`
To create a compiler pass it needs to implement the :class:`Symfony\\Component\\DependencyInjection\\Compiler\\CompilerPassInterface`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Altough it isn´t you fault, can you please put the :class:... part on the next line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, but why? I've looked at other parts of the document, and :class:... parts are inlined everywhere.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the documentation we use a 'line break point' around 72-80 characters, it don't look nice if a link is much longer. If you place it in a new line it looks a bit nicer.

@weaverryan
Copy link
Member

Hi Denis!

Nice fix, I've patched this into the 2.0 branch at sha: 85e5a39. About the line-break, it's no big deal - the breaking of these long class or method lines onto its own line (instead of having a very long line) is something we've done more and more with the docs. Anyways, I've added it :)

Thanks guys!

@weaverryan weaverryan closed this Nov 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants