-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Changed normal links to special :php*: links #1967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed normal links to special :php*: links
Awesome, thanks! |
It turns out that the
I think we should do the second thing, what is your opinion about this @weaverryan and @fabpot? |
I've already reverted these (so done option 1). I'd be very cool with option (2) as well - it looks like it's already implemented in that file, but just needs to have the role added as you mentioned. @wouterj - it should be quite simple - do you want to try it and PR over to fabpot's repository? |
Thank you @weaverryan ! It is not implemented in that file yet (the EDIT: I did some research and I will create that role. It is quite easy. |
This PR was merged into the master branch. Commits ------- ab2c3e7 Created phpmethod role Discussion ---------- Created phpmethod role We already have a `:phpfunction:` and `:phpclass:` role, it would be easy to have a `:phpmethod:` role to link to methods of PHP classes too. (see symfony/symfony-docs#1967 for more information) This PR creates a basic role. I have copy/past some code from the `:method:` and `:phpclass:` roles to create this function. I just started with Python, so the code can be buggy.
No description provided.