Changing some uses of let's #1968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Let's walk through a simple implementation that generates the ETag as the | ||
| md5 of the content:: | ||
| As an example here is a simple implementation that generates the ETag as | ||
| the md5 of the content:: |
There was a problem hiding this comment.
Hmm, how about:
To see a simple implementation, generate the ETag as the md5 of the content::
|
Hey Richard! I think you're doing all the right things. Some of the "let's" are definitely more difficult, but let's (<-- pun intended) just keep changing things to use the second-person command format instead of this (e.g. "change things to use the second-person command format") ;) |
|
I have made the changes you have suggested, will keep working on the others for another PR when I can |
weaverryan
added a commit
that referenced
this pull request
Nov 26, 2012
Changing some uses of let's
|
Thanks Richard! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There still quite a lot of uses of let's, these are more difficult to change as it is not just a case of swapping the word used and is quite often a change of the style sentences are written in, often making it sounds more formal. @weaverryan what do you think about how to deal with these?