-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Document the mapped form type option #1973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This option seems to be there since 2.1, hence the pull request branch. |
@@ -0,0 +1,7 @@ | |||
property_path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops :) - be sure to change this to "mapped"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is what you get when copy/pasting too hastily :P Good catch!
@@ -12,3 +12,6 @@ name. | |||
|
|||
If you wish the field to be ignored when reading or writing to the object | |||
you can set the ``property_path`` option to ``false`` | |||
|
|||
.. versionadded:: 2.1 | |||
Since 2.1, the ``mapped`` option has been added for this use-case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a perfect note, but actually the entire previous sentence needs to be changed as well. Setting property_path
to false
only works for 2.0, mapped
completely replaces that for 2.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you dead sure about this? I just checked out origin/2.1, and there is a comment suggesting otherwise right here : https://github.com/symfony/symfony/blob/2.1/src/Symfony/Component/Form/Extension/Core/Type/FormType.php#L187 ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think it's just there fore backwards compatibility. So, we should say that using property_path
=> false
to disable mapping is now deprecated and to use mapped
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed, it is only kept for BC until 2.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weaverryan : I added something to point that out.
Document the mapped form type option
Awesome Grégoire! |
I didn't document the default value, I suppose it is true, because I don't know if there is one or if this option is just ignored when not set (I think it is the latter when looking at FormType.php).