[DependencyInjection] Updating prepend extension capabilities #19738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1bc6338 to
42b1bd2
Compare
alexandre-daubois
approved these changes
Apr 4, 2024
42b1bd2 to
02a258d
Compare
javiereguiluz
added a commit
that referenced
this pull request
Apr 15, 2024
…pend extension method (yceruto) This PR was merged into the 6.4 branch. Discussion ---------- [DependencyInjection] Discourage appending config on prepend extension method Related to symfony/symfony#52789 and #19738 Commits ------- 4e82adb Discourage append config on prepend extension method
02a258d to
25c5adf
Compare
|
Rebased done. |
|
Yonel, thanks for this and the other contribution (and thanks for the related code contribution too). While merging I reworded it a bit to use a |
|
Thanks Javier! Again, it's better than mine👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19735
I'm also suggesting removing the append example in the prepend extension method. As explained in PR symfony/symfony#52843 and related issues, it's flawed and should be discouraged from the official documentation.
I'll create a new PR to target the lower branch and remove it there too.