[FrameworkBundle] Add support for setting headers with TemplateContoller
#19911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
907fd69 to
e33c2f6
Compare
alamirault
reviewed
May 22, 2024
There was a problem hiding this comment.
Thanks for your contribution.
I left some comments
(I didn't see your PR before do it one my side 🙈 , you can take inspiration of mine 7.1...alamirault:symfony-docs:feature/19909-headers-template-controller)
templates.rst
Outdated
Comment on lines
708
to
711
| # add headers in response | ||
| headers: | ||
| Content-Type: 'image/svg+xml' | ||
| foo: 'bar' |
There was a problem hiding this comment.
Suggested change
| # add headers in response | |
| headers: | |
| Content-Type: 'image/svg+xml' | |
| foo: 'bar' | |
| # optionally you can define HTTP headers to add to the response | |
| headers: | |
| Content-Type: 'text/html' | |
| foo: 'bar' |
| headers: | ||
| Content-Type: 'image/svg+xml' | ||
| foo: 'bar' | ||
|
|
||
| .. code-block:: xml | ||
|
|
||
| <!-- config/routes.xml --> |
There was a problem hiding this comment.
Can you also update xml and php examples ?
| headers: | ||
| Content-Type: 'image/svg+xml' | ||
| foo: 'bar' | ||
|
|
||
| .. code-block:: xml | ||
|
|
||
| <!-- config/routes.xml --> |
There was a problem hiding this comment.
Foreach new feature, we add directive versionadded to tell is new. You can add it above Checking if a Template Exists title
.. versionadded:: 7.2
The ``headers`` option was introduced in Symfony 7.2.
There was a problem hiding this comment.
Good information 👍
|
@alamirault thanks for your help, very good work, happy to see how to do a good PR |
OskarStark
approved these changes
May 23, 2024
|
Thank you Tim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19909