-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Documenting the Console Helpers #1999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…the Formatter Helper
GitHub don't let me create a PR on your repo, but you should change this format issues: wouterj/symfony-docs@69ce6c9 |
@wouterj Done. I think to be able to make a PR you would need to add my repository as a new remote, pull my branch and make changes. Maybe there is a better way like giving you push access to my repository or you giving me push access. |
@Sgoettschkes well, I added your repo as a remote and have based my commit on your branch. But in order to create a PR on github you should choose a branch in the dropdown list and it looks like Github doesn't refresh it if the main repo is forked by a new user. So your repo was not in the list of repo's to request a PR and I wasn't able to add you in there... |
I would love to see this merged so we can get started documenting the new ProgressHelper and new DialogHelper capabilities. Any change requests for this PR? |
@Sgoettschkes 👍, but be aware that the ProgressHelper is already documented (it is included in the |
Hi Sebastian! Sorry for the delay on merging this - it's a really great PR! I've now merged it in and made only a few minor changes. As @wouterj said, the Thanks! |
@Sgoettschkes are you going to document these new helpers/features? (otherwise I will d it) |
As said I'll do it. I'll also take care of adding the new features as menttioned in #2022! |
ok, great job! (almost all components are documented right now 🚴) |
As suggested in #1811, this PR includes documention on the two Console Helpers:
The new documents are included in the index and checked for sphinx issues.