[TypeInfo] Better explain the getBaseType() method
#20017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javiereguiluz, I just created the PR symfony/symfony#57630 which rethinks and improves the component design and usage. Therefore, I'd wait for this PR to be either merged or closed before going further 🙂 |
|
Thanks Mathias ... but this PR only adds some short explanations about existing code examples. Even if your PR is accepted, it will merged in 7.2 branch, so I think it's OK to change this in 7.1 branch meanwhile. |
getBaseType() method
|
Merged for the reasons explained above. If the changes proposed in the new code PR are merged, we'll keep updating these docs. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19843.
@mtarld if you have some time, please review this PR. Thanks a lot!