Skip to content

[Security] use access decision manager to control which token to vote on #20388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[Security] use access decision manager to control which token to vote on #20388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions security/impersonating_user.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,17 +309,17 @@ logic you want::
namespace App\Security\Voter;

use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authorization\AccessDecisionManagerInterface;
use Symfony\Component\Security\Core\Authorization\Voter\Voter;
use Symfony\Component\Security\Core\Security;
use Symfony\Component\Security\Core\User\UserInterface;

class SwitchToCustomerVoter extends Voter
{
private $security;
private $accessDecisionManager;

public function __construct(Security $security)
public function __construct(AccessDecisionManager $accessDecisionManager)
{
$this->security = $security;
$this->accessDecisionManager = $accessDecisionManager;
}

protected function supports($attribute, $subject): bool
Expand All @@ -337,12 +337,12 @@ logic you want::
}

// you can still check for ROLE_ALLOWED_TO_SWITCH
if ($this->security->isGranted('ROLE_ALLOWED_TO_SWITCH')) {
if ($this->accessDecisionManager->isGranted($token, ['ROLE_ALLOWED_TO_SWITCH'])) {
return true;
}

// check for any roles you want
if ($this->security->isGranted('ROLE_TECH_SUPPORT')) {
if ($this->accessDecisionManager->isGranted($token, ['ROLE_TECH_SUPPORT'])) {
return true;
}

Expand Down
16 changes: 8 additions & 8 deletions security/voters.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,33 +222,33 @@ Checking for Roles inside a Voter
---------------------------------

What if you want to call ``isGranted()`` from *inside* your voter - e.g. you want
to see if the current user has ``ROLE_SUPER_ADMIN``. That's possible by injecting
the :class:`Symfony\\Component\\Security\\Core\\Security`
into your voter. You can use this to, for example, *always* allow access to a user
to see if the current user has ``ROLE_SUPER_ADMIN``. That's possible by using an
:class:`access decision manager <Symfony\\Component\\Security\\Core\\Authorization\\AccessDecisionManagerInterface>`
inside your voter. You can use this to, for example, *always* allow access to a user
with ``ROLE_SUPER_ADMIN``::

// src/Security/PostVoter.php

// ...
use Symfony\Component\Security\Core\Security;
use Symfony\Component\Security\Core\Authorization\AccessDecisionManagerInterface;

class PostVoter extends Voter
{
// ...

private $security;
private $accessDecisionManager;

public function __construct(Security $security)
public function __construct(AccessDecisionManagerInterface $accessDecisionManager)
{
$this->security = $security;
$this->accessDecisionManager = $accessDecisionManager;
}

protected function voteOnAttribute($attribute, $subject, TokenInterface $token): bool
{
// ...

// ROLE_SUPER_ADMIN can do anything! The power!
if ($this->security->isGranted('ROLE_SUPER_ADMIN')) {
if ($this->accessDecisionManager->isGranted($token, ['ROLE_SUPER_ADMIN'])) {
return true;
}

Expand Down
Loading