Skip to content

Add must usage in coding standards #20468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add must usage in coding standards #20468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions contributing/code/standards.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,9 @@ Structure
- throw new \Exception(sprintf('Command "%s" failed.', $command::class));
+ throw new \Exception(sprintf('Command "%s" failed.', get_debug_type($command)));

* User-oriented exception, error and deprecation messages must not use ``must``. Instead,
alternative phrasing should be used: ``should``, ``needs to``, ``has to``, etc.

* Do not use ``else``, ``elseif``, ``break`` after ``if`` and ``case`` conditions
which return or throw something;

Expand Down
Loading