Skip to content

[book, quick_tour, reference] updated documentation according to the rec... #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2012

Conversation

hhamon
Copy link
Contributor

@hhamon hhamon commented Dec 21, 2012

...ent CVE-2012-6431 security advisory regarding the Twig render tag and ESI management.

…recent CVE-2012-6431 security advisory regarding the Twig render tag and ESI management.
@hhamon
Copy link
Contributor Author

hhamon commented Dec 21, 2012

@fabpot can you please review it to make sure it's ok or if we need to add extra information.


.. code-block:: php

<?php echo $view['actions']->render('...:news', array(), array('standalone' => true)) ?>
<?php echo $view['actions']->render('...:news', array('max' => 5), array('standalone' => true)) ?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated too, to use the new syntax instead of the deprecated one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the render php method also takes an URL?

weaverryan added a commit that referenced this pull request Dec 24, 2012
[book, quick_tour, reference] updated documentation according to the rec...
@weaverryan weaverryan merged commit 89617bd into symfony:2.0 Dec 24, 2012
weaverryan added a commit that referenced this pull request Dec 24, 2012
@weaverryan
Copy link
Member

Hi guys!

I've merged this in, and also went through and re-read things to try to catch any other needed changes. @hhamon thanks for doing this PR first - much easier when there are 2 of us checking for things :). My extra commits are attached to this PR, if anyone sees anything else, let me know!

I wish everyone wonderful holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants