Added constraints PHP format and some code tweaks #2083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change from Length to MinLength is indeed good for 2.0 (as Length does not exist in 2.0) but it will need to be changed back in 2.1 as MinLength is deprecated |
| { | ||
| public static function loadValidatorMetadata(ClassMetadata $metadata) | ||
| { | ||
| $metadata->addPropertyConstraint('firstName', new Assetc\Blank()); |
There was a problem hiding this comment.
Should be new Assert\Blank() probably ? :)
weaverryan
added a commit
that referenced
this pull request
Jan 3, 2013
Added constraints PHP format and some code tweaks
weaverryan
added a commit
that referenced
this pull request
Jan 3, 2013
|
Hey WouterJ! Happy new year to you too (nice touch with the fireworks)! This is a great PR, I've merged it in with just a few tweaks, including the one mentioned by @l3l0. Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the PHP format for all PHP constraints, namespaces in every Yml and PHP format and fixes some spacing issues.
I think this is my last PR this year (well, I hope it is) so: Happy new Year 🎆 to every Symfony contributor and especially @weaverryan!