Adding notes about Extension registration to the DI component #2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richardmiller-zz
commented
Jan 20, 2013
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | yes |
| Applies to | all |
| use Symfony\Component\DependencyInjection\Loader\YamlFileLoader; | ||
|
|
||
| $container = new ContainerBuilder(); | ||
| $extension = new AcmeDemoExtension; |
There was a problem hiding this comment.
Shouldn't this be new AcmeDemoExtension();?
There was a problem hiding this comment.
Certainly can be and is then consistent with the line above. Out of interest is there something about this in the CS standard regarding this?
There was a problem hiding this comment.
I haven't found it yet. We should maybe add this to the symfony CS as it is generally used in the core framework.
There was a problem hiding this comment.
I'm not sure it is written in the doc, but it is applied in the code
weaverryan
added a commit
that referenced
this pull request
Jan 20, 2013
Adding notes about Extension registration to the DI component
|
Nice work guys :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.