Add comment on http_digest auth. #2170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just thought it would be usefull to see what keys are needed to get HTTP Digest Auth working.
| -------------------------- | ||
|
|
||
| To use HTTP-Digest authentication you need to provide a realm and a key: | ||
| .. configuration-block:: |
There was a problem hiding this comment.
You should put an empty line before this
add empty line
Added PHP and XML examples.
|
@wouterj: Thanks! Examples added. |
| .. configuration-block:: | ||
|
|
||
| .. code-block:: yaml | ||
| # app/config/security.yml |
There was a problem hiding this comment.
Put an empty line after .. code-block:: (same below)
Formatting fixes, added file comments.
|
Done :) |
| realm: "secure-api" | ||
|
|
||
| .. code-block:: xml | ||
| <!-- app/config/security.xml --> |
There was a problem hiding this comment.
You forgot a new line here 👊 ;)
|
👍 it's ready for merge (apart from that last change) |
fix newline
weaverryan
added a commit
that referenced
this pull request
Jan 25, 2013
Add comment on http_digest auth.
weaverryan
added a commit
that referenced
this pull request
Jan 25, 2013
|
Hi guys! Thanks for working together on this! I've merged this into master and then backported it to 2.0, since it applies to all branches (and unfortunately, it didn't patch cleanly directly to 2.0) - you can see the patch at sha: d1a79dc Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just thought it would be usefull to see what keys are needed to get HTTP Digest Auth working.