Adding a note describing the configuration of SQLite with doctrine #2196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add the pull request format to your PR message next time? |
| dbal: | ||
| driver: pdo_sqlite | ||
| path: %kernel.root_dir%/sqlite.db | ||
| charset: UTF8 |
There was a problem hiding this comment.
You should also add a XML and PHP example:
<!-- app/config/config.xml -->
<doctrine:config
driver="pdo_sqlite"
path="%kernel.root_dir%/sqlite.db"
charset="UTF-8"
>
<!-- ... -->
</doctrine:config>// app/config/config.php
$container->loadFromExtension('doctrine', array(
'dbal' => array(
'driver' => 'pdo_sqlite',
'path' => '%kernel.root_dir%/sqlite.db',
'charset' => 'UTF-8',
),
));|
I changed the PR description. I didn't knew about this new format. |
| 'path' => '%kernel.root_dir%/sqlite.db', | ||
| 'charset' => 'UTF-8', | ||
| ), | ||
| )); |
There was a problem hiding this comment.
You should put the code blocks in a configuration block:
.. configuration-block::
.. code-block:: yml
# ...
.. code-block:: xml
<!-- ... -->
.. code-block:: php
// ...
weaverryan
added a commit
that referenced
this pull request
Feb 11, 2013
Adding a note describing the configuration of SQLite with doctrine
weaverryan
added a commit
that referenced
this pull request
Feb 11, 2013
… has so many notes and sidebars already
|
Thanks Sebastian and Wouter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1638, the doctrine configuration option for SQLite was added as a note (including the correct configuration for the driver and the encoding setting).