Add cookbook for e-mail testing with Symfony2 profiler #2201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ``SwiftmailerBundle``, which leverages the power of the `Swiftmailer`_ library. | ||
|
|
||
| To functionally test that e-mails are sent, and even assert their subjects, | ||
| content or any other headers we can use the Symfony2 :ref:`Profiler <internals-profiler>`. |
There was a problem hiding this comment.
I prefer to do it like this:
... we can use :ref:`the Symfony2 Profiler <internals-profiler>`.
|
Fixed @wouterj comments, waiting for comments on a better sentence to introduce Functional Test |
| And the ``WebTestCase`` to assert the e-mail content should be similar to:: | ||
|
|
||
| // src/Acme/DemoBundle/Tests/Controller/MailControllerTest.php | ||
|
|
There was a problem hiding this comment.
you should remove this empty line
weaverryan
added a commit
that referenced
this pull request
Feb 3, 2013
Add cookbook for e-mail testing with Symfony2 profiler
weaverryan
added a commit
that referenced
this pull request
Feb 3, 2013
|
Awesome work Ricard - thanks very much for this! I made minor tweaks at sha: f60eac8 - let me know if you see anything you don't like! Thanks! |
|
Thanks for fixing my "not so good" (to say the least) English :) And regarding the change to POST in the functional test, I agree with the change, 99,99999% of the times such an action will be POST and not GET :) Thanks for merging, always glad to contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As always, waiting for your comments and improvements on this!