Skip to content

Adding two use statements to virtual form cookbook page #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Adding two use statements to virtual form cookbook page #2216

wants to merge 1 commit into from

Conversation

theunraveler
Copy link

These two examples are missing the use statement for the AbstractType class.

Once fixed in master, this should probably also be backported to the 2.1 docs as well (it's missing there).

@wouterj
Copy link
Member

wouterj commented Feb 5, 2013

It is better to base this PR on the oldest branch in which it should be merged. For now, @weaverryan can do some cherry picking, but it would be easier to do so the next time :) You should also include the PR format next time, to speed up the proces.

@theunraveler
Copy link
Author

Thanks. I'll definitely stick to both of those next time.

@weaverryan
Copy link
Member

Hi Jake!

This is nice find and fix! I've patched it into the 2.1 branch at sha: da352a9 - and the changes will be merged up into 2.2 and master. The changes needed were slightly different in 2.0, but I've backported them as well in sha: 347688a.

Thanks for the nice fix and PR!

@weaverryan weaverryan closed this Mar 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants