[Installation] Improve setfacl options #2240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
added a commit
that referenced
this pull request
Feb 25, 2013
[Installation] Improve setfacl options
|
Hi Philipp! Well done - very technical, thanks for checking into this and for the detailed PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve setfacl options to avoid existing files gaining unwanted x-bit permission.
When setting the ACL for all existing files and directory recursivly, an uppercase "X" should be used in the permission options. It means granting the x-bit only to those files which already have it. Otherwise existing files like .gitkeep or existing cache and log files are provided with the x-bit.
See setfacl man page for more details (section "ACL ENTRIES"):
http://manpages.ubuntu.com/manpages/precise/en/man1/setfacl.1.html