Skip to content

[Cookbook][Bundles][Extension] Fix typos and improve readability #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2013

Conversation

johnkary
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to 2.1, master
Fixed tickets none

Thanks!
🚀

``Extension::getConfiguration()`` method. Have it return an instance of your
``__construct()`` it will work automatically. If you have something
different, your ``Extension`` class must override the
``Extension::getConfiguration()`` method and return an instance of your
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use an API doc link here:

:method:`Extension::getConfiguration() <Symfony\\Component\\HttpKernel\\DependencyInjection\\Extension::getConfiguration>`
method and return an instance of your

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it here, also for a second instance in the article for Symfony\Component\HttpKernel\Bundle\Bundle::build

@wouterj
Copy link
Member

wouterj commented Feb 19, 2013

great job! 👍

weaverryan added a commit that referenced this pull request Feb 23, 2013
[Cookbook][Bundles][Extension] Fix typos and improve readability
@weaverryan weaverryan merged commit 6010340 into symfony:2.1 Feb 23, 2013
@weaverryan
Copy link
Member

Awesome John, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants