Skip to content

Correcting the link to the clearCookie method. #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mikeSimonson
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to all (or 2.0+)
Fixed tickets no ticket

@@ -329,7 +329,7 @@ method takes an instance of
:class:`Symfony\\Component\\HttpFoundation\\Cookie` as an argument.

You can clear a cookie via the
:method:`Symfony\\Component\\HttpFoundation\\Response::clearCookie` method.
:method:`Symfony\\Component\\HttpFoundation\\ResponseHeaderBag::method_clearCookie` method.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove the method_ part

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

What's the best way ?
Should I make a new pull request and close this one and if how ?
Should I make a new one ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should go to the patch-1 branch ( mikeSimonson/symfony-docs@patch-1 ) and go to this file. Then press the edit button, fix the issue and create a new commit. Then you are ready.

@weaverryan
Copy link
Member

Hi guys!

This is a very nice fix! I've patched this into the 2.0 branch at sha: d663ce0 and fixed the method name at sha: 388cde4 thanks to @wouterj.

Thanks!

@weaverryan weaverryan closed this Feb 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants